Closed
Conversation
this appears to have been deprecated since node 0.7. perhaps it’s time to remove it?
ljharb
added
the
semver-major
gengjiawen
approved these changes
Sep 29, 2020
aduh95
requested changes
Sep 29, 2020
Member
|
Ha, this keeps coming up every year or so. See #26292 (review) and #26292 (review) for why we're unlikely to ever remove it. Perhaps we should add a comment somewhere so people don't keep running into this. |
Member
Author
|
Thanks for the references, that's unfortunate. If opinions change and it's decided it's worth removing, i'll happily reopen and update the PR, otherwise it seems like this should be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this appears to have been deprecated since node 0.7. perhaps it’s time to remove it?
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes